Pros
Some of the best aspects of working at SpaceX include working with the brightest, vested and highly motivated engineers in a scrappy, meritocratic environment. The company mission is a noble one, and there are many opportunities for an engineer to push grow, build technical skills and think creatively. There is truly no parallel to engineering rockets, in terms of satisfaction, reward, stress and technical challenge. For both the good and bad that comes with it- SpaceX is a place that differentiates between the technically meek and brilliant. Many argue that career opportunities are limited, but the opportunities are there, it's just that the bar is set higher and not everyone is cut out to meet it.
Cons
Some of the cons include unrealistic schedules, overwhelming project pressure and the amount of personal sacrifice that comes with it. This is exacerbated by Elon's irrational drive for innovation, which sometimes leaves practicality as an afterthought. Base salaries for engineers are not as high as they could be, especially when considering the high expectations. Overall compensation is good, so long as the company is successful. Part of what makes SpaceX so great is the technical competency of the leadership team, but this can sometimes result in de-prioritized soft skills.